aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/staging
diff options
context:
space:
mode:
authorGao Xiang <gaoxiang25@huawei.com>2019-02-21 10:34:10 +0800
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2019-02-26 11:52:45 +0100
commitb2bb112db116585886eccf07d7392d23e1216279 (patch)
tree12f0f98052c9e57d59e6fe472e1700cfa6ad046c /drivers/staging
parentstaging: speakup: Note that simple_strtoul can't simply be replaced by kstrtoul (diff)
downloadlinux-dev-b2bb112db116585886eccf07d7392d23e1216279.tar.xz
linux-dev-b2bb112db116585886eccf07d7392d23e1216279.zip
staging: erofs: no need to take page lock in readdir
VFS will take inode_lock for readdir, therefore no need to take page lock in readdir at all just as the majority of other generic filesystems. Signed-off-by: Gao Xiang <gaoxiang25@huawei.com> Reviewed-by: Chao Yu <yuchao0@huawei.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/staging')
-rw-r--r--drivers/staging/erofs/dir.c2
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/staging/erofs/dir.c b/drivers/staging/erofs/dir.c
index e1955703ab8f..8f8ac9675921 100644
--- a/drivers/staging/erofs/dir.c
+++ b/drivers/staging/erofs/dir.c
@@ -98,7 +98,6 @@ static int erofs_readdir(struct file *f, struct dir_context *ctx)
if (IS_ERR(dentry_page))
continue;
- lock_page(dentry_page);
de = (struct erofs_dirent *)kmap(dentry_page);
nameoff = le16_to_cpu(de->nameoff);
@@ -128,7 +127,6 @@ static int erofs_readdir(struct file *f, struct dir_context *ctx)
skip_this:
kunmap(dentry_page);
- unlock_page(dentry_page);
put_page(dentry_page);
ctx->pos = blknr_to_addr(i) + ofs;