aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/target/iscsi
diff options
context:
space:
mode:
authorNicholas Bellinger <nab@linux-iscsi.org>2017-04-11 16:24:16 -0700
committerNicholas Bellinger <nab@linux-iscsi.org>2017-05-04 20:01:39 -0700
commita71a5dc7f833943998e97ca8fa6a4c708a0ed1a9 (patch)
treeade47401f759e833d0b74849049882c815a51003 /drivers/target/iscsi
parenttcmu: Recalculate the tcmu_cmd size to save cmd area memories (diff)
downloadlinux-dev-a71a5dc7f833943998e97ca8fa6a4c708a0ed1a9.tar.xz
linux-dev-a71a5dc7f833943998e97ca8fa6a4c708a0ed1a9.zip
target: Fix compare_and_write_callback handling for non GOOD status
Following the bugfix for handling non SAM_STAT_GOOD COMPARE_AND_WRITE status during COMMIT phase in commit 9b2792c3da1, the same bug exists for the READ phase as well. This would manifest first as a lost SCSI response, and eventual hung task during fabric driver logout or re-login, as existing shutdown logic waited for the COMPARE_AND_WRITE se_cmd->cmd_kref to reach zero. To address this bug, compare_and_write_callback() has been changed to set post_ret = 1 and return TCM_LOGICAL_UNIT_COMMUNICATION_FAILURE as necessary to signal failure status. Reported-by: Bill Borsari <wgb@datera.io> Cc: Bill Borsari <wgb@datera.io> Tested-by: Gary Guo <ghg@datera.io> Cc: Gary Guo <ghg@datera.io> Cc: <stable@vger.kernel.org> # v4.1+ Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
Diffstat (limited to 'drivers/target/iscsi')
0 files changed, 0 insertions, 0 deletions