diff options
| author |   Christoph Hellwig <hch@lst.de> | 2022-04-15 06:52:32 +0200 |
|---|---|---|
| committer |   Jens Axboe <axboe@kernel.dk> | 2022-04-17 19:49:58 -0600 |
| commit | 179d8609d8424529e95021df939ed7b0b82b37f1 (patch) | |
| tree | 237900d63a1993a0b16b8fdf7b6313351f9392a2 /drivers/target/target_core_device.c | |
| parent | bfq: Make sure bfqg for which we are queueing requests is online (diff) | |
| download | linux-dev-179d8609d8424529e95021df939ed7b0b82b37f1.tar.xz linux-dev-179d8609d8424529e95021df939ed7b0b82b37f1.zip | |
target: remove an incorrect unmap zeroes data deduction
For block devices, the SCSI target drivers implements UNMAP as calls to
blkdev_issue_discard, which does not guarantee zeroing just because
Write Zeroes is supported.
Note that this does not affect the file backed path which uses
fallocate to punch holes.
Fixes: 2237498f0b5c ("target/iblock: Convert WRITE_SAME to blkdev_issue_zeroout")
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
Link: https://lore.kernel.org/r/20220415045258.199825-2-hch@lst.de
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'drivers/target/target_core_device.c')
| -rw-r--r-- | drivers/target/target_core_device.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/target/target_core_device.c b/drivers/target/target_core_device.c index 44bb380e7390..fa866acef5bb 100644 --- a/drivers/target/target_core_device.c +++ b/drivers/target/target_core_device.c @@ -850,7 +850,6 @@ bool target_configure_unmap_from_queue(struct se_dev_attrib *attrib, attrib->unmap_granularity = q->limits.discard_granularity / block_size; attrib->unmap_granularity_alignment = q->limits.discard_alignment / block_size; - attrib->unmap_zeroes_data = !!(q->limits.max_write_zeroes_sectors); return true; } EXPORT_SYMBOL(target_configure_unmap_from_queue); |