diff options
| author |   Joern Engel <joern@logfs.org> | 2014-09-17 15:11:28 -0700 |
|---|---|---|
| committer |   Nicholas Bellinger <nab@linux-iscsi.org> | 2014-09-17 15:11:28 -0700 |
| commit | 1481473b5656d8841f63c455594f340306c22cb0 (patch) | |
| tree | b721b2ad6def22494160da9ae3d68bf883d217f1 /drivers/target/target_core_fabric_configfs.c | |
| parent | target: Fix memory leak on error in target_fabric_make_mappedlun (diff) | |
| download | linux-dev-1481473b5656d8841f63c455594f340306c22cb0.tar.xz linux-dev-1481473b5656d8841f63c455594f340306c22cb0.zip | |
target: simplify target_fabric_make_lun error path
Coverity complained that lun_cg has been dereferenced in all paths
leading to NULL check. It didn't mention that only a single path could
lead there and the code can be simplified even further.
Signed-off-by: Joern Engel <joern@logfs.org>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
Diffstat (limited to 'drivers/target/target_core_fabric_configfs.c')
| -rw-r--r-- | drivers/target/target_core_fabric_configfs.c | 7 |
1 files changed, 2 insertions, 5 deletions
diff --git a/drivers/target/target_core_fabric_configfs.c b/drivers/target/target_core_fabric_configfs.c index 0638a672d911..dc6c781732ee 100644 --- a/drivers/target/target_core_fabric_configfs.c +++ b/drivers/target/target_core_fabric_configfs.c @@ -911,15 +911,12 @@ static struct config_group *target_fabric_make_lun( GFP_KERNEL); if (!port_stat_grp->default_groups) { pr_err("Unable to allocate port_stat_grp->default_groups\n"); - errno = -ENOMEM; - goto out; + kfree(lun_cg->default_groups); + return ERR_PTR(-ENOMEM); } target_stat_setup_port_default_groups(lun); return &lun->lun_group; -out: - kfree(lun_cg->default_groups); - return ERR_PTR(errno); } static void target_fabric_drop_lun( |