diff options
| author |   Dan Carpenter <error27@gmail.com> | 2011-03-14 04:06:01 -0700 |
|---|---|---|
| committer |   James Bottomley <James.Bottomley@suse.de> | 2011-03-23 11:36:29 -0500 |
| commit | 5dd7ed2e811d5cd12f31fb7f0c5ad0107d494a12 (patch) | |
| tree | f5a9318be8ce5460940e769b710a07cb60026940 /drivers/target/target_core_fabric_lib.c | |
| parent | [SCSI] target: Remove unnecessary hba_dev_list walk and se_clear_dev_ports legacy code (diff) | |
| download | linux-dev-5dd7ed2e811d5cd12f31fb7f0c5ad0107d494a12.tar.xz linux-dev-5dd7ed2e811d5cd12f31fb7f0c5ad0107d494a12.zip | |
[SCSI] target: Minor sparse warning fixes and annotations
This patch addresses the majority of sparse warnings and adds
proper locking annotations. It also fixes the dubious one-bit signed
bitfield, for which the signed one-bit types can be 0 or -1 which can
cause a problem if someone ever checks if (foo->lu_gp_assoc == 1).
The current code is fine because everyone just checks zero vs non-zero.
But Sparse complains about it so lets change it. The warnings look like
this:
include/target/target_core_base.h:228:26: error: dubious one-bit signed bitfield
Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Fubo Chen <fubo.chen@gmail.com>
Signed-off-by: Nicholas A. Bellinger <nab@linux-iscsi.org>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
Diffstat (limited to 'drivers/target/target_core_fabric_lib.c')
| -rw-r--r-- | drivers/target/target_core_fabric_lib.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/target/target_core_fabric_lib.c b/drivers/target/target_core_fabric_lib.c index a3c695adabec..d57ad672677f 100644 --- a/drivers/target/target_core_fabric_lib.c +++ b/drivers/target/target_core_fabric_lib.c @@ -34,6 +34,7 @@ #include <target/target_core_base.h> #include <target/target_core_device.h> #include <target/target_core_transport.h> +#include <target/target_core_fabric_lib.h> #include <target/target_core_fabric_ops.h> #include <target/target_core_configfs.h> |