diff options
| author |   Nicholas Bellinger <nab@linux-iscsi.org> | 2015-02-14 01:32:11 +0000 |
|---|---|---|
| committer | Nicholas Bellinger <nab@linux-iscsi.org> | 2015-02-14 02:09:45 +0000 |
| commit | afd73f1b60fc5883ea4982f68e9522e77b28f1e5 (patch) | |
| tree | c8bfb7f917842b9cc8d0f0f24e71f3be869ba420 /drivers/target/target_core_file.c | |
| parent | target: Fail I/O with PROTECT bit when protection is unsupported (diff) | |
| download | linux-dev-afd73f1b60fc5883ea4982f68e9522e77b28f1e5.tar.xz linux-dev-afd73f1b60fc5883ea4982f68e9522e77b28f1e5.zip | |
target: Perform PROTECT sanity checks for WRITE_SAME
This patch adds a call to sbc_check_prot() within sbc_setup_write_same()
code to perform the various protection releated sanity checks, including
failing if WRPROTECT or RDPROTECT is set for a backend device that has
not advertised support for T10-PI.
Also, since WRITE_SAME + T10-PI is currently not supported by IBLOCK +
FILEIO backends, go ahead and fail if ->execute_write_same() is invoked
with a non zero cmd->prot_op.
Cc: Martin Petersen <martin.petersen@oracle.com>
Cc: Sagi Grimberg <sagig@mellanox.com>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
Diffstat (limited to 'drivers/target/target_core_file.c')
| -rw-r--r-- | drivers/target/target_core_file.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/drivers/target/target_core_file.c b/drivers/target/target_core_file.c index c2aea099ea4a..9f1ed773e976 100644 --- a/drivers/target/target_core_file.c +++ b/drivers/target/target_core_file.c @@ -494,6 +494,11 @@ fd_execute_write_same(struct se_cmd *cmd) target_complete_cmd(cmd, SAM_STAT_GOOD); return 0; } + if (cmd->prot_op) { + pr_err("WRITE_SAME: Protection information with FILEIO" + " backends not supported\n"); + return TCM_LOGICAL_UNIT_COMMUNICATION_FAILURE; + } sg = &cmd->t_data_sg[0]; if (cmd->t_data_nents > 1 || |