diff options
| author |   Jiang Yi <jiangyilism@gmail.com> | 2017-08-11 11:29:44 +0800 |
|---|---|---|
| committer |   Nicholas Bellinger <nab@linux-iscsi.org> | 2017-11-04 14:45:16 -0700 |
| commit | 594e25e73440863981032d76c9b1e33409ceff6e (patch) | |
| tree | 932965773742a5cd807a4768a15a92eee8a8632a /drivers/target | |
| parent | Linux 4.14-rc6 (diff) | |
| download | linux-dev-594e25e73440863981032d76c9b1e33409ceff6e.tar.xz linux-dev-594e25e73440863981032d76c9b1e33409ceff6e.zip | |
target/file: Do not return error for UNMAP if length is zero
The function fd_execute_unmap() in target_core_file.c calles
ret = file->f_op->fallocate(file, mode, pos, len);
Some filesystems implement fallocate() to return error if
length is zero (e.g. btrfs) but according to SCSI Block
Commands spec UNMAP should return success for zero length.
Signed-off-by: Jiang Yi <jiangyilism@gmail.com>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
Diffstat (limited to 'drivers/target')
| -rw-r--r-- | drivers/target/target_core_file.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/drivers/target/target_core_file.c b/drivers/target/target_core_file.c index c629817a8854..9b2c0c773022 100644 --- a/drivers/target/target_core_file.c +++ b/drivers/target/target_core_file.c @@ -482,6 +482,10 @@ fd_execute_unmap(struct se_cmd *cmd, sector_t lba, sector_t nolb) struct inode *inode = file->f_mapping->host; int ret; + if (!nolb) { + return 0; + } + if (cmd->se_dev->dev_attrib.pi_prot_type) { ret = fd_do_prot_unmap(cmd, lba, nolb); if (ret) |