aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/target
diff options
context:
space:
mode:
authorAndy Grover <agrover@redhat.com>2015-07-09 09:56:47 -0700
committerNicholas Bellinger <nab@linux-iscsi.org>2015-07-23 23:39:59 -0700
commitbc1a7d6aff763ea29db6319185327f86b0fe93b6 (patch)
tree98fba4ef9a5f113a886107661de56dbd579194c6 /drivers/target
parenttcm_qla2xxx: pass timeout as HZ independent value (diff)
downloadlinux-dev-bc1a7d6aff763ea29db6319185327f86b0fe93b6.tar.xz
linux-dev-bc1a7d6aff763ea29db6319185327f86b0fe93b6.zip
target: Indicate success if writing 0 to pi_prot_type
See https://bugzilla.redhat.com/show_bug.cgi?id=1240687 Returning 0 from a configfs store function results in infinite retries. Reported-by: Yanko Kaneti <yaneti@declera.com> Signed-off-by: Andy Grover <agrover@redhat.com> Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
Diffstat (limited to 'drivers/target')
-rw-r--r--drivers/target/target_core_configfs.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/target/target_core_configfs.c b/drivers/target/target_core_configfs.c
index 0b0de3647478..cb09e6988b56 100644
--- a/drivers/target/target_core_configfs.c
+++ b/drivers/target/target_core_configfs.c
@@ -747,7 +747,7 @@ static ssize_t store_pi_prot_type(struct se_dev_attrib *da,
if (!dev->transport->init_prot || !dev->transport->free_prot) {
/* 0 is only allowed value for non-supporting backends */
if (flag == 0)
- return 0;
+ return count;
pr_err("DIF protection not supported by backend: %s\n",
dev->transport->name);