diff options
| author |   Daniel Lezcano <daniel.lezcano@linaro.org> | 2017-10-19 19:05:43 +0200 |
|---|---|---|
| committer |   Eduardo Valentin <edubezval@gmail.com> | 2017-10-31 19:32:14 -0700 |
| commit | c176b10b025acee4dc8f2ab1cd64eb73b5ccef53 (patch) | |
| tree | ab6cf771abe8e5e02f67dfda64effb829cd331f8 /drivers/thermal/hisi_thermal.c | |
| parent | thermal: ti-soc-thermal: Fix ti_thermal_unregister_cpu_cooling NULL pointer on unload (diff) | |
| download | linux-dev-c176b10b025acee4dc8f2ab1cd64eb73b5ccef53.tar.xz linux-dev-c176b10b025acee4dc8f2ab1cd64eb73b5ccef53.zip | |
thermal/drivers/hisi: Fix missing interrupt enablement
The interrupt for the temperature threshold is not enabled at the end of the
probe function, enable it after the setup is complete.
On the other side, the irq_enabled is not correctly set as we are checking if
the interrupt is masked where 'yes' means irq_enabled=false.
irq_get_irqchip_state(data->irq, IRQCHIP_STATE_MASKED,
&data->irq_enabled);
As we are always enabling the interrupt, it is pointless to check if
the interrupt is masked or not, just set irq_enabled to 'true'.
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Reviewed-by: Leo Yan <leo.yan@linaro.org>
Tested-by: Leo Yan <leo.yan@linaro.org>
Signed-off-by: Eduardo Valentin <edubezval@gmail.com>
Diffstat (limited to 'drivers/thermal/hisi_thermal.c')
| -rw-r--r-- | drivers/thermal/hisi_thermal.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/drivers/thermal/hisi_thermal.c b/drivers/thermal/hisi_thermal.c index bd3572c41585..8381696241d6 100644 --- a/drivers/thermal/hisi_thermal.c +++ b/drivers/thermal/hisi_thermal.c @@ -345,8 +345,7 @@ static int hisi_thermal_probe(struct platform_device *pdev) } hisi_thermal_enable_bind_irq_sensor(data); - irq_get_irqchip_state(data->irq, IRQCHIP_STATE_MASKED, - &data->irq_enabled); + data->irq_enabled = true; for (i = 0; i < HISI_MAX_SENSORS; ++i) { ret = hisi_thermal_register_sensor(pdev, data, @@ -358,6 +357,8 @@ static int hisi_thermal_probe(struct platform_device *pdev) hisi_thermal_toggle_sensor(&data->sensors[i], true); } + enable_irq(data->irq); + return 0; } |