diff options
| author |   Dmitry Osipenko <digetx@gmail.com> | 2021-06-16 22:04:13 +0300 |
|---|---|---|
| committer |   Daniel Lezcano <daniel.lezcano@linaro.org> | 2021-07-04 18:28:04 +0200 |
| commit | 5e5c9f9a75fc4532980c2e699caf8a36070a3a2e (patch) | |
| tree | 7f98c38316c22849c4bebd0ab69293d0f377d308 /drivers/thermal | |
| parent | dt-bindings: thermal: Add binding for Tegra30 thermal sensor (diff) | |
| download | linux-dev-5e5c9f9a75fc4532980c2e699caf8a36070a3a2e.tar.xz linux-dev-5e5c9f9a75fc4532980c2e699caf8a36070a3a2e.zip | |
thermal/core/thermal_of: Stop zone device before unregistering it
Zone device is enabled after thermal_zone_of_sensor_register() completion,
but it's not disabled before senor is unregistered, leaving temperature
polling active. This results in accessing a disabled zone device and
produces a warning about this problem. Stop zone device before
unregistering it in order to fix this "use-after-free" problem.
Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Link: https://lore.kernel.org/r/20210616190417.32214-3-digetx@gmail.com
Diffstat (limited to 'drivers/thermal')
| -rw-r--r-- | drivers/thermal/thermal_of.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/thermal/thermal_of.c b/drivers/thermal/thermal_of.c index 5b76f9a1280d..6379f26a335f 100644 --- a/drivers/thermal/thermal_of.c +++ b/drivers/thermal/thermal_of.c @@ -559,6 +559,9 @@ void thermal_zone_of_sensor_unregister(struct device *dev, if (!tz) return; + /* stop temperature polling */ + thermal_zone_device_disable(tzd); + mutex_lock(&tzd->lock); tzd->ops->get_temp = NULL; tzd->ops->get_trend = NULL; |