aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/thermal
diff options
context:
space:
mode:
authorDavid HERNANDEZ SANCHEZ <david.hernandezsanchez@st.com>2018-12-06 13:23:32 +0000
committerEduardo Valentin <edubezval@gmail.com>2018-12-10 20:15:28 -0800
commit99c47fcd4daa2b9a1348872ba49226dcdc58cb40 (patch)
treed59ad886e8fbfc354fd9dfedbf9bea5b160c5b42 /drivers/thermal
parentthermal: stm32: read factory settings inside stm_thermal_prepare (diff)
downloadlinux-dev-99c47fcd4daa2b9a1348872ba49226dcdc58cb40.tar.xz
linux-dev-99c47fcd4daa2b9a1348872ba49226dcdc58cb40.zip
thermal: stm32: Fix stm_thermal_read_factory_settings
Adding brackets allows to multiply the register value, masked by TS1_RAMP_COEFF_MASK, by an ADJUST value properly and not to multiply ADJUST by register value and then mask the whole. Fixes: 1d693155 ("thermal: add stm32 thermal driver") Reviewed-by: Daniel Lezcano <daniel.lezcano@linaro.org> Signed-off-by: David Hernandez Sanchez <david.hernandezsanchez@st.com> Signed-off-by: Eduardo Valentin <edubezval@gmail.com>
Diffstat (limited to 'drivers/thermal')
-rw-r--r--drivers/thermal/st/stm_thermal.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/thermal/st/stm_thermal.c b/drivers/thermal/st/stm_thermal.c
index daa1257809a6..bbd73c5a4a4e 100644
--- a/drivers/thermal/st/stm_thermal.c
+++ b/drivers/thermal/st/stm_thermal.c
@@ -241,8 +241,8 @@ static int stm_thermal_read_factory_settings(struct stm_thermal_sensor *sensor)
sensor->t0 = TS1_T0_VAL1;
/* Retrieve fmt0 and put it on Hz */
- sensor->fmt0 = ADJUST * readl_relaxed(sensor->base + DTS_T0VALR1_OFFSET)
- & TS1_FMT0_MASK;
+ sensor->fmt0 = ADJUST * (readl_relaxed(sensor->base +
+ DTS_T0VALR1_OFFSET) & TS1_FMT0_MASK);
/* Retrieve ramp coefficient */
sensor->ramp_coeff = readl_relaxed(sensor->base + DTS_RAMPVALR_OFFSET) &