diff options
| author |   Arnd Bergmann <arnd@arndb.de> | 2021-09-27 15:16:11 +0200 |
|---|---|---|
| committer |   Mika Westerberg <mika.westerberg@linux.intel.com> | 2021-09-28 12:28:54 +0300 |
| commit | 0a0624a26f9ceb8aae16882d87dc3b12f17f4a49 (patch) | |
| tree | 7e56bd65e4a8ad3a2c2b35f78defd7e94dc8ba9c /drivers/thunderbolt | |
| parent | thunderbolt: Enable retry logic for intra-domain control packets (diff) | |
| download | linux-dev-0a0624a26f9ceb8aae16882d87dc3b12f17f4a49.tar.xz linux-dev-0a0624a26f9ceb8aae16882d87dc3b12f17f4a49.zip | |
thunderbolt: Fix -Wrestrict warning
gcc-11 warns when building with W=1:
drivers/thunderbolt/xdomain.c: In function 'modalias_show':
drivers/thunderbolt/xdomain.c:733:16: error: 'sprintf' argument 3 overlaps destination object 'buf' [-Werror=restrict]
733 | return sprintf(buf, "%s\n", buf);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
drivers/thunderbolt/xdomain.c:727:36: note: destination object referenced by 'restrict'-qualified argument 1 was declared here
727 | char *buf)
| ~~~~~~^~~
There is no need for the sprintf() here when a strcat() does
the same thing.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Diffstat (limited to 'drivers/thunderbolt')
| -rw-r--r-- | drivers/thunderbolt/xdomain.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/thunderbolt/xdomain.c b/drivers/thunderbolt/xdomain.c index d66ea4d616fd..eff32499610f 100644 --- a/drivers/thunderbolt/xdomain.c +++ b/drivers/thunderbolt/xdomain.c @@ -730,7 +730,7 @@ static ssize_t modalias_show(struct device *dev, struct device_attribute *attr, /* Full buffer size except new line and null termination */ get_modalias(svc, buf, PAGE_SIZE - 2); - return sprintf(buf, "%s\n", buf); + return strlen(strcat(buf, "\n")); } static DEVICE_ATTR_RO(modalias); |