diff options
| author |   Andreas Noever <andreas.noever@gmail.com> | 2016-04-10 12:48:27 +0200 |
|---|---|---|
| committer |   Bjorn Helgaas <bhelgaas@google.com> | 2016-05-02 12:09:22 -0500 |
| commit | 2ffa9a5d76a75abbc1f95c17959fced666095bdd (patch) | |
| tree | 2bbf292cfa62e714e7544cbdd4436f9e6a2fc03c /drivers/thunderbolt | |
| parent | thunderbolt: Support 1st gen Light Ridge controller (diff) | |
| download | linux-dev-2ffa9a5d76a75abbc1f95c17959fced666095bdd.tar.xz linux-dev-2ffa9a5d76a75abbc1f95c17959fced666095bdd.zip | |
thunderbolt: Fix double free of drom buffer
If tb_drom_read() fails, sw->drom is freed but not set to NULL. sw->drom
is then freed again in the error path of tb_switch_alloc().
The bug can be triggered by unplugging a thunderbolt device shortly after
it is detected by the thunderbolt driver.
Clear sw->drom if tb_drom_read() fails.
[bhelgaas: add Fixes:, stable versions of interest]
Fixes: 343fcb8c70d7 ("thunderbolt: Fix nontrivial endpoint devices.")
Signed-off-by: Andreas Noever <andreas.noever@gmail.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
CC: stable@vger.kernel.org # v3.17+
CC: Lukas Wunner <lukas@wunner.de>
Diffstat (limited to 'drivers/thunderbolt')
| -rw-r--r-- | drivers/thunderbolt/eeprom.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/thunderbolt/eeprom.c b/drivers/thunderbolt/eeprom.c index 0c052e25c5bc..2b9602c2c355 100644 --- a/drivers/thunderbolt/eeprom.c +++ b/drivers/thunderbolt/eeprom.c @@ -449,6 +449,7 @@ int tb_drom_read(struct tb_switch *sw) return tb_drom_parse_entries(sw); err: kfree(sw->drom); + sw->drom = NULL; return -EIO; } |