diff options
| author |   Sachin Kamat <sachin.kamat@linaro.org> | 2012-09-12 12:00:01 +0530 |
|---|---|---|
| committer |   Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2012-09-17 04:45:30 -0700 |
| commit | e740d8f1a0a23a8fea8fbc5a02013c7410283665 (patch) | |
| tree | 384c981882e45970d2f4f35cd7424023a5647cd6 /drivers/tty/serial/samsung.c | |
| parent | tty: n_gsm: Fix incorrect debug display (diff) | |
| download | linux-dev-e740d8f1a0a23a8fea8fbc5a02013c7410283665.tar.xz linux-dev-e740d8f1a0a23a8fea8fbc5a02013c7410283665.zip | |
tty: serial: Samsung: Fix return value
Return the value returned by the failing function instead
of -1 (which does not convey the right error information).
Fixes the following smatch warning:
drivers/tty/serial/samsung.c:1687 s3c24xx_serial_modinit() info:
why not propagate 'ret' from uart_register_driver() instead of -1?
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/tty/serial/samsung.c')
| -rw-r--r-- | drivers/tty/serial/samsung.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/tty/serial/samsung.c b/drivers/tty/serial/samsung.c index bdaa06f3ab69..8eef1141b81d 100644 --- a/drivers/tty/serial/samsung.c +++ b/drivers/tty/serial/samsung.c @@ -1684,7 +1684,7 @@ static int __init s3c24xx_serial_modinit(void) ret = uart_register_driver(&s3c24xx_uart_drv); if (ret < 0) { pr_err("Failed to register Samsung UART driver\n"); - return -1; + return ret; } return platform_driver_register(&samsung_serial_driver); |