diff options
| author |   Dan Carpenter <dan.carpenter@oracle.com> | 2017-07-17 11:12:38 +0300 |
|---|---|---|
| committer |   Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2017-07-17 13:19:19 +0200 |
| commit | 2b01bfaeb41e1563322448d9b392ac924cbf22ef (patch) | |
| tree | 20b8d4ee07b8cb5daac89be69597a3bcf4ed0ed9 /drivers/tty/serial/st-asc.c | |
| parent | Linux v4.13-rc1 (diff) | |
| download | linux-dev-2b01bfaeb41e1563322448d9b392ac924cbf22ef.tar.xz linux-dev-2b01bfaeb41e1563322448d9b392ac924cbf22ef.zip | |
serial: st-asc: Potential error pointer dereference
It looks like we intended to return an error code here, because we
dereference "ascport->pinctrl" on the next lines.
Fixes: 6929cb00a501 ("serial: st-asc: Read in all Pinctrl states")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Lee Jones <lee.jones@linaro.org>
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/tty/serial/st-asc.c')
| -rw-r--r-- | drivers/tty/serial/st-asc.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/tty/serial/st-asc.c b/drivers/tty/serial/st-asc.c index f5335be344f6..6b0ca65027d0 100644 --- a/drivers/tty/serial/st-asc.c +++ b/drivers/tty/serial/st-asc.c @@ -758,6 +758,7 @@ static int asc_init_port(struct asc_port *ascport, if (IS_ERR(ascport->pinctrl)) { ret = PTR_ERR(ascport->pinctrl); dev_err(&pdev->dev, "Failed to get Pinctrl: %d\n", ret); + return ret; } ascport->states[DEFAULT] = |