diff options
| author |   Nava kishore Manne <nava.manne@xilinx.com> | 2019-06-12 13:14:39 +0200 |
|---|---|---|
| committer |   Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2019-06-18 09:34:27 +0200 |
| commit | 26d5a3245b3f3ce406277e7584f7ccbbd5ea98bb (patch) | |
| tree | 9fd9e5ba9d19bb2e45bdf17f55a7621acd538105 /drivers/tty/serial | |
| parent | serial: uartps: Use the same dynamic major number for all ports (diff) | |
| download | linux-dev-26d5a3245b3f3ce406277e7584f7ccbbd5ea98bb.tar.xz linux-dev-26d5a3245b3f3ce406277e7584f7ccbbd5ea98bb.zip | |
serial: uartps: Use octal permission for module_param()
Octal permission is preffered compare to symbolic one.
This patch fixes checkpatch warnings:
Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal
permissions '0444'.
Fixes: 85baf542d54e ("tty: xuartps: support 64 byte FIFO size")
Signed-off-by: Nava kishore Manne <nava.manne@xilinx.com>
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/tty/serial')
| -rw-r--r-- | drivers/tty/serial/xilinx_uartps.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c index 73ae0cacc961..32cf67598bc3 100644 --- a/drivers/tty/serial/xilinx_uartps.c +++ b/drivers/tty/serial/xilinx_uartps.c @@ -37,12 +37,12 @@ /* Rx Trigger level */ static int rx_trigger_level = 56; static int uartps_major; -module_param(rx_trigger_level, uint, S_IRUGO); +module_param(rx_trigger_level, uint, 0444); MODULE_PARM_DESC(rx_trigger_level, "Rx trigger level, 1-63 bytes"); /* Rx Timeout */ static int rx_timeout = 10; -module_param(rx_timeout, uint, S_IRUGO); +module_param(rx_timeout, uint, 0444); MODULE_PARM_DESC(rx_timeout, "Rx timeout, 1-255"); /* Register offsets for the UART. */ |