diff options
| author |   Jiri Slaby <jslaby@suse.cz> | 2021-06-18 08:14:56 +0200 |
|---|---|---|
| committer |   Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2021-06-18 13:10:02 +0200 |
| commit | 42ad25fc46d3f6b6fe5b4b933dd328677e328ec7 (patch) | |
| tree | 11d579bd8d2fd738fec66b52f19b830f5e415765 /drivers/tty | |
| parent | mxser: cleanup mxser_process_txrx_fifo (diff) | |
| download | linux-dev-42ad25fc46d3f6b6fe5b4b933dd328677e328ec7.tar.xz linux-dev-42ad25fc46d3f6b6fe5b4b933dd328677e328ec7.zip | |
mxser: rework and simplify mxser_open
In mxser_open, tty->port is already set thanks to
tty_port_register_device in ->probe. So we can simply use container_of
to deduce the struct mxser_port's pointer. Thus avoiding divisions and
complex computations.
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Link: https://lore.kernel.org/r/20210618061516.662-51-jslaby@suse.cz
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/tty')
| -rw-r--r-- | drivers/tty/mxser.c | 11 |
1 files changed, 4 insertions, 7 deletions
diff --git a/drivers/tty/mxser.c b/drivers/tty/mxser.c index 1e54e94a7ca6..ea5e61a5a173 100644 --- a/drivers/tty/mxser.c +++ b/drivers/tty/mxser.c @@ -856,15 +856,12 @@ static void mxser_shutdown_port(struct tty_port *port) */ static int mxser_open(struct tty_struct *tty, struct file *filp) { - struct mxser_port *info; - int line = tty->index; + struct tty_port *tport = tty->port; + struct mxser_port *port = container_of(tport, struct mxser_port, port); - info = &mxser_boards[line / MXSER_PORTS_PER_BOARD].ports[line % MXSER_PORTS_PER_BOARD]; - if (!info->ioaddr) - return -ENODEV; + tty->driver_data = port; - tty->driver_data = info; - return tty_port_open(&info->port, tty, filp); + return tty_port_open(tport, tty, filp); } static void mxser_flush_buffer(struct tty_struct *tty) |