diff options
| author |   Marek Szyprowski <m.szyprowski@samsung.com> | 2017-04-03 08:21:01 +0200 |
|---|---|---|
| committer |   Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2017-04-08 18:58:52 +0200 |
| commit | 469f813ffe1ab74a9115dbd06ea3026e50ea6a54 (patch) | |
| tree | 95c648d13e92bc489adbafddb4c8a782106ed0cd /drivers/tty | |
| parent | serial: samsung: Add missing checks for dma_map_single failure (diff) | |
| download | linux-dev-469f813ffe1ab74a9115dbd06ea3026e50ea6a54.tar.xz linux-dev-469f813ffe1ab74a9115dbd06ea3026e50ea6a54.zip | |
serial: samsung: Remove useless spinlock
Spinlock taken only for dma_map_single() for TX buffer is completely
useless and doesn't protect anything, so remove it to simplify the code.
Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/tty')
| -rw-r--r-- | drivers/tty/serial/samsung.c | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/drivers/tty/serial/samsung.c b/drivers/tty/serial/samsung.c index ca0bcd7fd61f..8aca18c4cdea 100644 --- a/drivers/tty/serial/samsung.c +++ b/drivers/tty/serial/samsung.c @@ -906,13 +906,9 @@ static int s3c24xx_serial_request_dma(struct s3c24xx_uart_port *p) goto err_free_rx; } - spin_lock_irqsave(&p->port.lock, flags); - /* TX buffer */ dma->tx_addr = dma_map_single(p->port.dev, p->port.state->xmit.buf, UART_XMIT_SIZE, DMA_TO_DEVICE); - - spin_unlock_irqrestore(&p->port.lock, flags); if (dma_mapping_error(p->port.dev, dma->tx_addr)) { ret = -EIO; goto err_unmap_rx; |