aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/tty
diff options
context:
space:
mode:
authorNava kishore Manne <nava.manne@xilinx.com>2019-06-12 13:14:40 +0200
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2019-06-18 09:34:27 +0200
commitb6415f243919703c97483a29ff918872f66f165c (patch)
tree294fe746c15dc03577341ed7eb217936409d048a /drivers/tty
parentserial: uartps: Use octal permission for module_param() (diff)
downloadlinux-dev-b6415f243919703c97483a29ff918872f66f165c.tar.xz
linux-dev-b6415f243919703c97483a29ff918872f66f165c.zip
serial: uartps: Fix multiple line dereference
Trivial patch which fixes this checkpatch warning: WARNING: Avoid multiple line dereference - prefer 'port->state->xmit.tail' + port->state->xmit.buf[port->state->xmit. + tail], port->membase + CDNS_UART_FIFO); Fixes: c8dbdc842d30 ("serial: xuartps: Rewrite the interrupt handling logic") Signed-off-by: Nava kishore Manne <nava.manne@xilinx.com> Signed-off-by: Michal Simek <michal.simek@xilinx.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/tty')
-rw-r--r--drivers/tty/serial/xilinx_uartps.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c
index 32cf67598bc3..2dff879f988e 100644
--- a/drivers/tty/serial/xilinx_uartps.c
+++ b/drivers/tty/serial/xilinx_uartps.c
@@ -321,8 +321,8 @@ static void cdns_uart_handle_tx(void *dev_id)
* register.
*/
writel(
- port->state->xmit.buf[port->state->xmit.
- tail], port->membase + CDNS_UART_FIFO);
+ port->state->xmit.buf[port->state->xmit.tail],
+ port->membase + CDNS_UART_FIFO);
port->icount.tx++;