diff options
| author |   Dan Carpenter <dan.carpenter@oracle.com> | 2021-09-06 12:42:21 +0300 |
|---|---|---|
| committer |   Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2021-09-14 10:32:27 +0200 |
| commit | 17956b53ebff6a490baf580a836cbd3eae94892b (patch) | |
| tree | 2ad32ed1e180a6fa70902e84809f70267b6a90d2 /drivers/usb/cdns3/cdns3-gadget.c | |
| parent | usb: gadget: u_audio: EP-OUT bInterval in fback frequency (diff) | |
| download | linux-dev-17956b53ebff6a490baf580a836cbd3eae94892b.tar.xz linux-dev-17956b53ebff6a490baf580a836cbd3eae94892b.zip | |
usb: gadget: r8a66597: fix a loop in set_feature()
This loop is supposed to loop until if reads something other than
CS_IDST or until it times out after 30,000 attempts. But because of
the || vs && bug, it will never time out and instead it will loop a
minimum of 30,000 times.
This bug is quite old but the code is only used in USB_DEVICE_TEST_MODE
so it probably doesn't affect regular usage.
Fixes: 96fe53ef5498 ("usb: gadget: r8a66597-udc: add support for TEST_MODE")
Cc: stable <stable@vger.kernel.org>
Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Acked-by: Felipe Balbi <balbi@kernel.org>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/20210906094221.GA10957@kili
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/usb/cdns3/cdns3-gadget.c')
0 files changed, 0 insertions, 0 deletions