diff options
| author |   Thinh Nguyen <Thinh.Nguyen@synopsys.com> | 2022-04-21 19:22:31 -0700 |
|---|---|---|
| committer |   Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2022-05-05 22:03:22 +0200 |
| commit | 69e131d1ac4e52a59ec181ab4f8aa8c48cd8fb64 (patch) | |
| tree | bf34bf4fcce2787e86621c8f6cdc49d7a254b6fe /drivers/usb/dwc3/gadget.c | |
| parent | usb: dwc3: xilinx: Add gpio-reset support (diff) | |
| download | linux-dev-69e131d1ac4e52a59ec181ab4f8aa8c48cd8fb64.tar.xz linux-dev-69e131d1ac4e52a59ec181ab4f8aa8c48cd8fb64.zip | |
usb: dwc3: gadget: Prevent repeat pullup()
Don't do soft-disconnect if it's previously done. Likewise, don't do
soft-connect if the device is currently connected and running. It would
break normal operation.
Currently the caller of pullup() (udc's sysfs soft_connect) only checks
if it had initiated disconnect to prevent repeating soft-disconnect. It
doesn't check for soft-connect. To be safe, let's keep the check here
regardless whether the udc core is fixed.
Signed-off-by: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
Link: https://lore.kernel.org/r/1c1345bd66c97a9d32f77d63aaadd04b7b037143.1650593829.git.Thinh.Nguyen@synopsys.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/usb/dwc3/gadget.c')
| -rw-r--r-- | drivers/usb/dwc3/gadget.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c index 5b1d79528da3..e9c992be8472 100644 --- a/drivers/usb/dwc3/gadget.c +++ b/drivers/usb/dwc3/gadget.c @@ -2514,6 +2514,10 @@ static int dwc3_gadget_pullup(struct usb_gadget *g, int is_on) int ret; is_on = !!is_on; + + if (dwc->pullups_connected == is_on) + return 0; + dwc->softconnect = is_on; /* * Per databook, when we want to stop the gadget, if a control transfer |