diff options
| author |   Lorenzo Colitti <lorenzo@google.com> | 2020-08-25 14:55:05 +0900 |
|---|---|---|
| committer |   Felipe Balbi <balbi@kernel.org> | 2020-10-02 09:57:41 +0300 |
| commit | 7974ecd7d3c0f42a98566f281e44ea8573a2ad88 (patch) | |
| tree | 8b3b9be50772560e3c9cf37074794660f9a49eaa /drivers/usb/gadget/function/f_ncm.c | |
| parent | usb: gadget: f_ncm: set SuperSpeed bulk descriptor bMaxBurst to 15 (diff) | |
| download | linux-dev-7974ecd7d3c0f42a98566f281e44ea8573a2ad88.tar.xz linux-dev-7974ecd7d3c0f42a98566f281e44ea8573a2ad88.zip | |
usb: gadget: f_ncm: allow using NCM in SuperSpeed Plus gadgets.
Currently, enabling f_ncm at SuperSpeed Plus speeds results in an
oops in config_ep_by_speed because ncm_set_alt passes in NULL
ssp_descriptors. Fix this by re-using the SuperSpeed descriptors.
This is safe because usb_assign_descriptors calls
usb_copy_descriptors.
Tested: enabled f_ncm on a dwc3 gadget and 10Gbps link, ran iperf
Reviewed-by: Maciej Żenczykowski <maze@google.com>
Signed-off-by: Lorenzo Colitti <lorenzo@google.com>
Signed-off-by: Felipe Balbi <balbi@kernel.org>
Diffstat (limited to 'drivers/usb/gadget/function/f_ncm.c')
| -rw-r--r-- | drivers/usb/gadget/function/f_ncm.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/usb/gadget/function/f_ncm.c b/drivers/usb/gadget/function/f_ncm.c index ffa397a1c3d4..019bea8e09cc 100644 --- a/drivers/usb/gadget/function/f_ncm.c +++ b/drivers/usb/gadget/function/f_ncm.c @@ -1536,7 +1536,7 @@ static int ncm_bind(struct usb_configuration *c, struct usb_function *f) fs_ncm_notify_desc.bEndpointAddress; status = usb_assign_descriptors(f, ncm_fs_function, ncm_hs_function, - ncm_ss_function, NULL); + ncm_ss_function, ncm_ss_function); if (status) goto fail; |