diff options
| author |   Gustavo A. R. Silva <gustavo@embeddedor.com> | 2019-11-06 14:28:21 -0600 |
|---|---|---|
| committer |   Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2019-11-07 11:14:51 +0100 |
| commit | 66d1b0c0580b7f1b1850ee4423f32ac42afa2e92 (patch) | |
| tree | 3fbaef7be14feefc43af971dbd021437a9da1d76 /drivers/usb/gadget/udc/pch_udc.c | |
| parent | dt-bindings: usb: renesas: usb3-peri: convert bindings to json-schema (diff) | |
| download | linux-dev-66d1b0c0580b7f1b1850ee4423f32ac42afa2e92.tar.xz linux-dev-66d1b0c0580b7f1b1850ee4423f32ac42afa2e92.zip | |
usb: gadget: pch_udc: fix use after free
Remove pointer dereference after free.
pci_pool_free doesn't care about contents of td.
It's just a void* for it
Addresses-Coverity-ID: 1091173 ("Use after free")
Cc: stable@vger.kernel.org
Acked-by: Michal Nazarewicz <mina86@mina86.com>
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Link: https://lore.kernel.org/r/20191106202821.GA20347@embeddedor
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/usb/gadget/udc/pch_udc.c')
| -rw-r--r-- | drivers/usb/gadget/udc/pch_udc.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/usb/gadget/udc/pch_udc.c b/drivers/usb/gadget/udc/pch_udc.c index 265dab2bbfac..3344fb8c4181 100644 --- a/drivers/usb/gadget/udc/pch_udc.c +++ b/drivers/usb/gadget/udc/pch_udc.c @@ -1519,7 +1519,6 @@ static void pch_udc_free_dma_chain(struct pch_udc_dev *dev, td = phys_to_virt(addr); addr2 = (dma_addr_t)td->next; dma_pool_free(dev->data_requests, td, addr); - td->next = 0x00; addr = addr2; } req->chain_len = 1; |