diff options
| author |   Johan Hovold <johan@kernel.org> | 2017-03-13 13:47:48 +0100 |
|---|---|---|
| committer |   Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2017-03-14 17:07:30 +0800 |
| commit | b0addd3fa6bcd119be9428996d5d4522479ab240 (patch) | |
| tree | 3768e9d858743a26feb196a4ae06a16b9a1f8cdc /drivers/usb/misc/idmouse.c | |
| parent | Linux 4.11-rc2 (diff) | |
| download | linux-dev-b0addd3fa6bcd119be9428996d5d4522479ab240.tar.xz linux-dev-b0addd3fa6bcd119be9428996d5d4522479ab240.zip | |
USB: idmouse: fix NULL-deref at probe
Make sure to check the number of endpoints to avoid dereferencing a
NULL-pointer should a malicious device lack endpoints.
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/usb/misc/idmouse.c')
| -rw-r--r-- | drivers/usb/misc/idmouse.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/usb/misc/idmouse.c b/drivers/usb/misc/idmouse.c index 8b9fd7534f69..502bfe30a077 100644 --- a/drivers/usb/misc/idmouse.c +++ b/drivers/usb/misc/idmouse.c @@ -347,6 +347,9 @@ static int idmouse_probe(struct usb_interface *interface, if (iface_desc->desc.bInterfaceClass != 0x0A) return -ENODEV; + if (iface_desc->desc.bNumEndpoints < 1) + return -ENODEV; + /* allocate memory for our device state and initialize it */ dev = kzalloc(sizeof(*dev), GFP_KERNEL); if (dev == NULL) |