diff options
| author |   Markus Elfring <elfring@users.sourceforge.net> | 2014-11-21 15:50:44 +0100 |
|---|---|---|
| committer |   Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2014-11-24 17:24:31 -0800 |
| commit | bb2d43e0919ad89077dc756167c2bcc3e4cc97ab (patch) | |
| tree | 67ec25e287a1be5e92407607dad6d25767a5bbb4 /drivers/usb/misc/sisusbvga/sisusb.c | |
| parent | USB-IP: Deletion of unnecessary checks before the function call "usb_put_dev" (diff) | |
| download | linux-dev-bb2d43e0919ad89077dc756167c2bcc3e4cc97ab.tar.xz linux-dev-bb2d43e0919ad89077dc756167c2bcc3e4cc97ab.zip | |
USB-SIS: Deletion of an unnecessary check before the function call "usb_put_dev"
The usb_put_dev() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/usb/misc/sisusbvga/sisusb.c')
| -rw-r--r-- | drivers/usb/misc/sisusbvga/sisusb.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/usb/misc/sisusbvga/sisusb.c b/drivers/usb/misc/sisusbvga/sisusb.c index 633caf643122..022dc0008f2a 100644 --- a/drivers/usb/misc/sisusbvga/sisusb.c +++ b/drivers/usb/misc/sisusbvga/sisusb.c @@ -2472,8 +2472,7 @@ sisusb_delete(struct kref *kref) if (!sisusb) return; - if (sisusb->sisusb_dev) - usb_put_dev(sisusb->sisusb_dev); + usb_put_dev(sisusb->sisusb_dev); sisusb->sisusb_dev = NULL; sisusb_free_buffers(sisusb); |