diff options
| author |   Fabio Baltieri <fabio.baltieri@linaro.org> | 2013-05-15 14:03:28 +0200 |
|---|---|---|
| committer |   Felipe Balbi <balbi@ti.com> | 2013-05-28 20:01:34 +0300 |
| commit | a96afc6b75cf9e7991a9b869246c5dca2a8a4e7a (patch) | |
| tree | 05743e26835f47e26663fb4ae0175a27f5b8beb7 /drivers/usb/phy/phy-ab8500-usb.c | |
| parent | usb: phy: ab8500-usb: restart phy during probe (diff) | |
| download | linux-dev-a96afc6b75cf9e7991a9b869246c5dca2a8a4e7a.tar.xz linux-dev-a96afc6b75cf9e7991a9b869246c5dca2a8a4e7a.zip | |
usb: phy: ab8500-usb: fix phy tuning value select logic
The driver supports both ab8500 and ab8505, but the actual phy tuning
values logic sets ab8500 values:
if (!is_ab8500_2p0_or_earlier(ab->ab8500))
which is supposed to set values for ab8500, but incorrectly results true
for ab8505 too.
Fix this by adding an additional is_ab8500(ab->ab8500) check.
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Acked-by: Maxime Coquelin <maxime.coquelin@st.com>
Signed-off-by: Fabio Baltieri <fabio.baltieri@linaro.org>
Signed-off-by: Felipe Balbi <balbi@ti.com>
Diffstat (limited to 'drivers/usb/phy/phy-ab8500-usb.c')
| -rw-r--r-- | drivers/usb/phy/phy-ab8500-usb.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/usb/phy/phy-ab8500-usb.c b/drivers/usb/phy/phy-ab8500-usb.c index 63bb7cc14a2a..e6d461943f84 100644 --- a/drivers/usb/phy/phy-ab8500-usb.c +++ b/drivers/usb/phy/phy-ab8500-usb.c @@ -835,8 +835,8 @@ static int ab8500_usb_probe(struct platform_device *pdev) return err; } - /* Phy tuning values for AB8500 */ - if (!is_ab8500_2p0_or_earlier(ab->ab8500)) { + /* Phy tuning values for AB8500 > v2.0 */ + if (is_ab8500(ab->ab8500) && !is_ab8500_2p0_or_earlier(ab->ab8500)) { /* Enable the PBT/Bank 0x12 access */ err = abx500_set_register_interruptible(ab->dev, AB8500_DEVELOPMENT, AB8500_BANK12_ACCESS, 0x01); |