diff options
| author |   Dan Carpenter <dan.carpenter@oracle.com> | 2013-11-08 01:43:17 -0800 |
|---|---|---|
| committer |   Felipe Balbi <balbi@ti.com> | 2013-11-25 15:53:43 -0600 |
| commit | 0b55149033403d78f345fb613d8ad52d16c161fc (patch) | |
| tree | 46aaa3bdcc23659c58e97839fbac61d475373d4f /drivers/usb/phy | |
| parent | usb: dwc3: power off usb phy in error path (diff) | |
| download | linux-dev-0b55149033403d78f345fb613d8ad52d16c161fc.tar.xz linux-dev-0b55149033403d78f345fb613d8ad52d16c161fc.zip | |
usb: phy: twl6030-usb: signedness bug in twl6030_readb()
"ret" needs to be signed for the error handling to work.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
Diffstat (limited to 'drivers/usb/phy')
| -rw-r--r-- | drivers/usb/phy/phy-twl6030-usb.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/usb/phy/phy-twl6030-usb.c b/drivers/usb/phy/phy-twl6030-usb.c index 30e8a61552d4..bad57ce77ba5 100644 --- a/drivers/usb/phy/phy-twl6030-usb.c +++ b/drivers/usb/phy/phy-twl6030-usb.c @@ -127,7 +127,8 @@ static inline int twl6030_writeb(struct twl6030_usb *twl, u8 module, static inline u8 twl6030_readb(struct twl6030_usb *twl, u8 module, u8 address) { - u8 data, ret = 0; + u8 data; + int ret; ret = twl_i2c_read_u8(module, &data, address); if (ret >= 0) |