diff options
| author |   Uwe Kleine-König <uwe@kleine-koenig.org> | 2021-02-08 15:31:49 +0100 |
|---|---|---|
| committer |   Johan Hovold <johan@kernel.org> | 2021-02-09 13:13:58 +0100 |
| commit | c5d1448fa353242635fa3e1fed6ab4558e0e7d9a (patch) | |
| tree | d74c1132f17bd3f0ad29a6565e887f541169bd00 /drivers/usb/serial/cp210x.c | |
| parent | USB: serial: drop if with an always false condition (diff) | |
| download | linux-dev-c5d1448fa353242635fa3e1fed6ab4558e0e7d9a.tar.xz linux-dev-c5d1448fa353242635fa3e1fed6ab4558e0e7d9a.zip | |
USB: serial: make remove callback return void
All usb_serial drivers return 0 in their remove callbacks and driver
core ignores the value returned by usb_serial_device_remove(). So change
the remove callback to return void and return 0 unconditionally in
usb_serial_device_remove().
Signed-off-by: Uwe Kleine-König <uwe@kleine-koenig.org>
Link: https://lore.kernel.org/r/20210208143149.963644-2-uwe@kleine-koenig.org
Signed-off-by: Johan Hovold <johan@kernel.org>
Diffstat (limited to 'drivers/usb/serial/cp210x.c')
| -rw-r--r-- | drivers/usb/serial/cp210x.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/drivers/usb/serial/cp210x.c b/drivers/usb/serial/cp210x.c index cc4f63a06f9e..665798043d3c 100644 --- a/drivers/usb/serial/cp210x.c +++ b/drivers/usb/serial/cp210x.c @@ -44,7 +44,7 @@ static int cp210x_attach(struct usb_serial *); static void cp210x_disconnect(struct usb_serial *); static void cp210x_release(struct usb_serial *); static int cp210x_port_probe(struct usb_serial_port *); -static int cp210x_port_remove(struct usb_serial_port *); +static void cp210x_port_remove(struct usb_serial_port *); static void cp210x_dtr_rts(struct usb_serial_port *port, int on); static void cp210x_process_read_urb(struct urb *urb); static void cp210x_enable_event_mode(struct usb_serial_port *port); @@ -1841,14 +1841,12 @@ static int cp210x_port_probe(struct usb_serial_port *port) return 0; } -static int cp210x_port_remove(struct usb_serial_port *port) +static void cp210x_port_remove(struct usb_serial_port *port) { struct cp210x_port_private *port_priv; port_priv = usb_get_serial_port_data(port); kfree(port_priv); - - return 0; } static void cp210x_init_max_speed(struct usb_serial *serial) |