diff options
| author |   Johan Hovold <johan@kernel.org> | 2020-01-22 11:15:26 +0100 |
|---|---|---|
| committer | Johan Hovold <johan@kernel.org> | 2020-01-23 09:10:58 +0100 |
| commit | 2988a8ae7476fe9535ab620320790d1714bdad1d (patch) | |
| tree | 5d10d97aab01630eb06f092a70f690b5ae543ec6 /drivers/usb/serial | |
| parent | USB: serial: garmin_gps: Use flexible-array member (diff) | |
| download | linux-dev-2988a8ae7476fe9535ab620320790d1714bdad1d.tar.xz linux-dev-2988a8ae7476fe9535ab620320790d1714bdad1d.zip | |
USB: serial: ir-usb: add missing endpoint sanity check
Add missing endpoint sanity check to avoid dereferencing a NULL-pointer
on open() in case a device lacks a bulk-out endpoint.
Note that prior to commit f4a4cbb2047e ("USB: ir-usb: reimplement using
generic framework") the oops would instead happen on open() if the
device lacked a bulk-in endpoint and on write() if it lacked a bulk-out
endpoint.
Fixes: f4a4cbb2047e ("USB: ir-usb: reimplement using generic framework")
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Cc: stable <stable@vger.kernel.org>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Johan Hovold <johan@kernel.org>
Diffstat (limited to 'drivers/usb/serial')
| -rw-r--r-- | drivers/usb/serial/ir-usb.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/usb/serial/ir-usb.c b/drivers/usb/serial/ir-usb.c index 302eb9530859..c3b06fc5a7f0 100644 --- a/drivers/usb/serial/ir-usb.c +++ b/drivers/usb/serial/ir-usb.c @@ -195,6 +195,9 @@ static int ir_startup(struct usb_serial *serial) struct usb_irda_cs_descriptor *irda_desc; int rates; + if (serial->num_bulk_in < 1 || serial->num_bulk_out < 1) + return -ENODEV; + irda_desc = irda_usb_find_class_desc(serial, 0); if (!irda_desc) { dev_err(&serial->dev->dev, |