diff options
| author |   Wei Yongjun <weiyongjun1@huawei.com> | 2021-03-08 09:48:39 +0000 |
|---|---|---|
| committer |   Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2021-03-10 09:37:18 +0100 |
| commit | f2d90e07b5df2c7745ae66d2d48cc350d3f1c7d2 (patch) | |
| tree | 0a0b6f4eb49a802a8a1fec793602dacb88ac09c1 /drivers/usb/typec/stusb160x.c | |
| parent | usb: typec: tps6598x: Fix return value check in tps6598x_probe() (diff) | |
| download | linux-dev-f2d90e07b5df2c7745ae66d2d48cc350d3f1c7d2.tar.xz linux-dev-f2d90e07b5df2c7745ae66d2d48cc350d3f1c7d2.zip | |
usb: typec: stusb160x: fix return value check in stusb160x_probe()
In case of error, the function device_get_named_child_node() returns
NULL pointer not ERR_PTR(). The IS_ERR() test in the return value check
should be replaced with NULL test.
Fixes: da0cb6310094 ("usb: typec: add support for STUSB160x Type-C controller family")
Reported-by: Hulk Robot <hulkci@huawei.com>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Reviewed-by: Amelie Delaunay <amelie.delaunay@foss.st.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Link: https://lore.kernel.org/r/20210308094839.3586773-1-weiyongjun1@huawei.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/usb/typec/stusb160x.c')
| -rw-r--r-- | drivers/usb/typec/stusb160x.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/usb/typec/stusb160x.c b/drivers/usb/typec/stusb160x.c index d21750bbbb44..6eaeba9b096e 100644 --- a/drivers/usb/typec/stusb160x.c +++ b/drivers/usb/typec/stusb160x.c @@ -682,8 +682,8 @@ static int stusb160x_probe(struct i2c_client *client) } fwnode = device_get_named_child_node(chip->dev, "connector"); - if (IS_ERR(fwnode)) - return PTR_ERR(fwnode); + if (!fwnode) + return -ENODEV; /* * When both VDD and VSYS power supplies are present, the low power |