aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/usb/typec
diff options
context:
space:
mode:
authorLiang He <windhl@126.com>2022-09-15 17:22:09 +0800
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2022-09-22 15:52:29 +0200
commite45d7337dc0e4f7f1c2876e1b22c71a544ad12fd (patch)
tree567d821c9a965363e78199778da670c24ab1dc47 /drivers/usb/typec
parentusb: gadget: add _init/__exit annotations to module init/exit funcs (diff)
downloadlinux-dev-e45d7337dc0e4f7f1c2876e1b22c71a544ad12fd.tar.xz
linux-dev-e45d7337dc0e4f7f1c2876e1b22c71a544ad12fd.zip
usb: typec: anx7411: Use of_get_child_by_name() instead of of_find_node_by_name()
In anx7411_typec_switch_probe(), we should call of_get_child_by_name() instead of of_find_node_by_name() as of_find_xxx API will decrease the refcount of the 'from' argument. Fixes: fe6d8a9c8e64 ("usb: typec: anx7411: Add Analogix PD ANX7411 support") Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> Signed-off-by: Liang He <windhl@126.com> Link: https://lore.kernel.org/r/20220915092209.4009273-1-windhl@126.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/usb/typec')
-rw-r--r--drivers/usb/typec/anx7411.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/usb/typec/anx7411.c b/drivers/usb/typec/anx7411.c
index c0f0842d443c..f178d0eb47b1 100644
--- a/drivers/usb/typec/anx7411.c
+++ b/drivers/usb/typec/anx7411.c
@@ -1105,7 +1105,7 @@ static int anx7411_typec_switch_probe(struct anx7411_data *ctx,
int ret;
struct device_node *node;
- node = of_find_node_by_name(dev->of_node, "orientation_switch");
+ node = of_get_child_by_name(dev->of_node, "orientation_switch");
if (!node)
return 0;
@@ -1115,7 +1115,7 @@ static int anx7411_typec_switch_probe(struct anx7411_data *ctx,
return ret;
}
- node = of_find_node_by_name(dev->of_node, "mode_switch");
+ node = of_get_child_by_name(dev->of_node, "mode_switch");
if (!node) {
dev_err(dev, "no typec mux exist");
ret = -ENODEV;