diff options
| author |   David Vrabel <david.vrabel@csr.com> | 2008-10-27 15:22:46 +0000 |
|---|---|---|
| committer | David Vrabel <david.vrabel@csr.com> | 2008-10-28 12:07:23 +0000 |
| commit | cae1c11414912bf77a62aebd65ced321f0b9da51 (patch) | |
| tree | 1f83b9b82aec7f86740f8b1f7f5e8be1c6cf3196 /drivers/usb/wusbcore | |
| parent | wusb: release mutex in the error path of whci-hcd's whc_do_gencmd() (diff) | |
| download | linux-dev-cae1c11414912bf77a62aebd65ced321f0b9da51.tar.xz linux-dev-cae1c11414912bf77a62aebd65ced321f0b9da51.zip | |
uwb: reference count reservations
Reference counting the struct uwb_rsv's is safer and easier to get right than
the transferring ownership of the structures from the PAL to reservation
manager.
This fixes an oops in the debug PAL after a reservation timed out.
Signed-off-by: David Vrabel <david.vrabel@csr.com>
Diffstat (limited to 'drivers/usb/wusbcore')
| -rw-r--r-- | drivers/usb/wusbcore/reservation.c | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/drivers/usb/wusbcore/reservation.c b/drivers/usb/wusbcore/reservation.c index fc63e77ded2d..7b6525dac2f1 100644 --- a/drivers/usb/wusbcore/reservation.c +++ b/drivers/usb/wusbcore/reservation.c @@ -59,7 +59,6 @@ static void wusbhc_rsv_complete_cb(struct uwb_rsv *rsv) case UWB_RSV_STATE_NONE: dev_dbg(dev, "removed reservation\n"); wusbhc_bwa_set(wusbhc, 0, NULL); - wusbhc->rsv = NULL; break; default: dev_dbg(dev, "unexpected reservation state: %d\n", rsv->state); @@ -105,11 +104,11 @@ int wusbhc_rsv_establish(struct wusbhc *wusbhc) /** - * wusbhc_rsv_terminate - terminate any cluster reservation + * wusbhc_rsv_terminate - terminate the cluster reservation * @wusbhc: the WUSB host whose reservation is to be terminated */ void wusbhc_rsv_terminate(struct wusbhc *wusbhc) { - if (wusbhc->rsv) - uwb_rsv_terminate(wusbhc->rsv); + uwb_rsv_terminate(wusbhc->rsv); + uwb_rsv_destroy(wusbhc->rsv); } |