diff options
| author |   Oliver Neukum <oneukum@suse.com> | 2016-04-04 14:30:53 +0200 |
|---|---|---|
| committer |   Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2016-04-13 11:53:07 -0700 |
| commit | 2a14759a03a0a57b2fc99b1e416180788b8ba24c (patch) | |
| tree | 0c7ddf79ac0ecf03dfd6ba25f8549dbf64fac276 /drivers/usb | |
| parent | Linux 4.6-rc3 (diff) | |
| download | linux-dev-2a14759a03a0a57b2fc99b1e416180788b8ba24c.tar.xz linux-dev-2a14759a03a0a57b2fc99b1e416180788b8ba24c.zip | |
cdc-acm: fix crash if flushed with nothing buffered
Under some circumstances acm_tty_flush_chars() is called
with no buffer to flush. We simply need to do nothing.
Signed-off-by: Oliver Neukum <ONeukum@suse.com>
Reported-by: Torsten Hilbrich <torsten.hilbrich@secunet.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/usb')
| -rw-r--r-- | drivers/usb/class/cdc-acm.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c index 83fd30b0577c..a6c4a1b895bd 100644 --- a/drivers/usb/class/cdc-acm.c +++ b/drivers/usb/class/cdc-acm.c @@ -744,11 +744,15 @@ static void acm_tty_flush_chars(struct tty_struct *tty) int err; unsigned long flags; + if (!cur) /* nothing to do */ + return; + acm->putbuffer = NULL; err = usb_autopm_get_interface_async(acm->control); spin_lock_irqsave(&acm->write_lock, flags); if (err < 0) { cur->use = 0; + acm->putbuffer = cur; goto out; } |