diff options
| author |   Yang Yingliang <yangyingliang@huawei.com> | 2022-09-22 21:33:22 +0800 |
|---|---|---|
| committer |   Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2022-09-27 10:37:00 +0200 |
| commit | e0b27d38ffb7552b28a993c3c7029ce89670ff5b (patch) | |
| tree | ffc33e056a86b963d77bcb82a25d876bd034f5f9 /drivers/usb | |
| parent | usb: ulpi: use DEFINE_SHOW_ATTRIBUTE to simplify ulpi_regs (diff) | |
| download | linux-dev-e0b27d38ffb7552b28a993c3c7029ce89670ff5b.tar.xz linux-dev-e0b27d38ffb7552b28a993c3c7029ce89670ff5b.zip | |
usb: phy: generic: Switch to use dev_err_probe() helper
In the probe path, dev_err() can be replaced with dev_err_probe()
which will check if error code is -EPROBE_DEFER and prints the
error name. It also sets the defer probe reason which can be
checked later through debugfs. It's more simple in error path.
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Link: https://lore.kernel.org/r/20220922133323.2135494-1-yangyingliang@huawei.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/usb')
| -rw-r--r-- | drivers/usb/phy/phy-generic.c | 9 |
1 files changed, 3 insertions, 6 deletions
diff --git a/drivers/usb/phy/phy-generic.c b/drivers/usb/phy/phy-generic.c index 34b9f8140187..3dc5c04e7cbf 100644 --- a/drivers/usb/phy/phy-generic.c +++ b/drivers/usb/phy/phy-generic.c @@ -230,12 +230,9 @@ int usb_phy_gen_create_phy(struct device *dev, struct usb_phy_generic *nop) err = PTR_ERR_OR_ZERO(nop->gpiod_vbus); } - if (err == -EPROBE_DEFER) - return -EPROBE_DEFER; - if (err) { - dev_err(dev, "Error requesting RESET or VBUS GPIO\n"); - return err; - } + if (err) + return dev_err_probe(dev, err, + "Error requesting RESET or VBUS GPIO\n"); if (nop->gpiod_reset) gpiod_direction_output(nop->gpiod_reset, 1); |