diff options
| author |   Alex Williamson <alex.williamson@redhat.com> | 2020-06-16 15:26:36 -0600 |
|---|---|---|
| committer | Alex Williamson <alex.williamson@redhat.com> | 2020-06-17 15:18:42 -0600 |
| commit | 5c5866c593bbd444d0339ede6a8fb5f14ff66d72 (patch) | |
| tree | 50fc4e075bbd78d84d2c1d65785f96aef6c77dbb /drivers/vfio | |
| parent | Linux 5.8-rc1 (diff) | |
| download | linux-dev-5c5866c593bbd444d0339ede6a8fb5f14ff66d72.tar.xz linux-dev-5c5866c593bbd444d0339ede6a8fb5f14ff66d72.zip | |
vfio/pci: Clear error and request eventfd ctx after releasing
The next use of the device will generate an underflow from the
stale reference.
Cc: Qian Cai <cai@lca.pw>
Fixes: 1518ac272e78 ("vfio/pci: fix memory leaks of eventfd ctx")
Reported-by: Daniel Wagner <dwagner@suse.de>
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
Tested-by: Daniel Wagner <dwagner@suse.de>
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
Diffstat (limited to 'drivers/vfio')
| -rw-r--r-- | drivers/vfio/pci/vfio_pci.c | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/drivers/vfio/pci/vfio_pci.c b/drivers/vfio/pci/vfio_pci.c index 7c0779018b1b..f634c81998bb 100644 --- a/drivers/vfio/pci/vfio_pci.c +++ b/drivers/vfio/pci/vfio_pci.c @@ -521,10 +521,14 @@ static void vfio_pci_release(void *device_data) vfio_pci_vf_token_user_add(vdev, -1); vfio_spapr_pci_eeh_release(vdev->pdev); vfio_pci_disable(vdev); - if (vdev->err_trigger) + if (vdev->err_trigger) { eventfd_ctx_put(vdev->err_trigger); - if (vdev->req_trigger) + vdev->err_trigger = NULL; + } + if (vdev->req_trigger) { eventfd_ctx_put(vdev->req_trigger); + vdev->req_trigger = NULL; + } } mutex_unlock(&vdev->reflck->lock); |