diff options
| author |   Zhang Changzhong <zhangchangzhong@huawei.com> | 2020-12-04 16:43:30 +0800 |
|---|---|---|
| committer |   Michael S. Tsirkin <mst@redhat.com> | 2020-12-18 16:14:31 -0500 |
| commit | 2e1139d613c7fb0956e82f72a8281c0a475ad4f8 (patch) | |
| tree | 10873fb3840ed14a21eaf1638619e5f8cf26cb7b /drivers/vhost/scsi.c | |
| parent | virtio_ring: Fix two use after free bugs (diff) | |
| download | linux-dev-2e1139d613c7fb0956e82f72a8281c0a475ad4f8.tar.xz linux-dev-2e1139d613c7fb0956e82f72a8281c0a475ad4f8.zip | |
vhost scsi: fix error return code in vhost_scsi_set_endpoint()
Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.
Fixes: 25b98b64e284 ("vhost scsi: alloc cmds per vq instead of session")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com>
Link: https://lore.kernel.org/r/1607071411-33484-1-git-send-email-zhangchangzhong@huawei.com
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Diffstat (limited to 'drivers/vhost/scsi.c')
| -rw-r--r-- | drivers/vhost/scsi.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/vhost/scsi.c b/drivers/vhost/scsi.c index 6ff8a5096691..4ce9f00ae10e 100644 --- a/drivers/vhost/scsi.c +++ b/drivers/vhost/scsi.c @@ -1643,7 +1643,8 @@ vhost_scsi_set_endpoint(struct vhost_scsi *vs, if (!vhost_vq_is_setup(vq)) continue; - if (vhost_scsi_setup_vq_cmds(vq, vq->num)) + ret = vhost_scsi_setup_vq_cmds(vq, vq->num); + if (ret) goto destroy_vq_cmds; } |