diff options
| author |   Sonny Rao <sonnyrao@chromium.org> | 2018-03-14 10:05:06 -0700 |
|---|---|---|
| committer |   Michael S. Tsirkin <mst@redhat.com> | 2018-03-20 03:17:42 +0200 |
| commit | 26b36604523f4a681a86e6cbc970ea72a2e9fb8a (patch) | |
| tree | fca51df6464b4ded7cc165b6ff0af386ad316b9b /drivers/vhost/vhost.c | |
| parent | fw_cfg: write vmcoreinfo details (diff) | |
| download | linux-dev-26b36604523f4a681a86e6cbc970ea72a2e9fb8a.tar.xz linux-dev-26b36604523f4a681a86e6cbc970ea72a2e9fb8a.zip | |
vhost: fix vhost ioctl signature to build with clang
Clang is particularly anal about signed vs unsigned comparisons and
doesn't like the fact that some ioctl numbers set the MSB, so we get
this error when trying to build vhost on aarch64:
drivers/vhost/vhost.c:1400:7: error: overflow converting case value to
switch condition type (3221794578 to 18446744072636378898)
[-Werror, -Wswitch]
case VHOST_GET_VRING_BASE:
3221794578 is 0xC008AF12 in hex
18446744072636378898 is 0xFFFFFFFFC008AF12 in hex
Fix this by using unsigned ints in the function signature for
vhost_vring_ioctl().
Signed-off-by: Sonny Rao <sonnyrao@chromium.org>
Reviewed-by: Darren Kenny <darren.kenny@oracle.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Diffstat (limited to 'drivers/vhost/vhost.c')
| -rw-r--r-- | drivers/vhost/vhost.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c index 1b3e8d2d5c8b..5316319d8408 100644 --- a/drivers/vhost/vhost.c +++ b/drivers/vhost/vhost.c @@ -1337,7 +1337,7 @@ err: return -EFAULT; } -long vhost_vring_ioctl(struct vhost_dev *d, int ioctl, void __user *argp) +long vhost_vring_ioctl(struct vhost_dev *d, unsigned int ioctl, void __user *argp) { struct file *eventfp, *filep = NULL; bool pollstart = false, pollstop = false; |