diff options
| author |   Laurent Vivier <lvivier@redhat.com> | 2021-03-12 15:09:13 +0100 |
|---|---|---|
| committer |   Michael S. Tsirkin <mst@redhat.com> | 2021-03-14 18:06:33 -0400 |
| commit | beb691e69f4dec7bfe8b81b509848acfd1f0dbf9 (patch) | |
| tree | 14a1afb60659ea37d0d2ca88ff62d8cf24a8ddfe /drivers/vhost/vhost.c | |
| parent | vhost_vdpa: fix the missing irq_bypass_unregister_producer() invocation (diff) | |
| download | linux-dev-beb691e69f4dec7bfe8b81b509848acfd1f0dbf9.tar.xz linux-dev-beb691e69f4dec7bfe8b81b509848acfd1f0dbf9.zip | |
vhost: Fix vhost_vq_reset()
vhost_reset_is_le() is vhost_init_is_le(), and in the case of
cross-endian legacy, vhost_init_is_le() depends on vq->user_be.
vq->user_be is set by vhost_disable_cross_endian().
But in vhost_vq_reset(), we have:
vhost_reset_is_le(vq);
vhost_disable_cross_endian(vq);
And so user_be is used before being set.
To fix that, reverse the lines order as there is no other dependency
between them.
Signed-off-by: Laurent Vivier <lvivier@redhat.com>
Link: https://lore.kernel.org/r/20210312140913.788592-1-lvivier@redhat.com
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Diffstat (limited to 'drivers/vhost/vhost.c')
| -rw-r--r-- | drivers/vhost/vhost.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c index a262e12c6dc2..5ccb0705beae 100644 --- a/drivers/vhost/vhost.c +++ b/drivers/vhost/vhost.c @@ -332,8 +332,8 @@ static void vhost_vq_reset(struct vhost_dev *dev, vq->error_ctx = NULL; vq->kick = NULL; vq->log_ctx = NULL; - vhost_reset_is_le(vq); vhost_disable_cross_endian(vq); + vhost_reset_is_le(vq); vq->busyloop_timeout = 0; vq->umem = NULL; vq->iotlb = NULL; |