diff options
| author |   Zheyu Ma <zheyuma97@gmail.com> | 2022-04-04 16:47:17 +0800 |
|---|---|---|
| committer |   Helge Deller <deller@gmx.de> | 2022-04-11 08:23:50 +0200 |
| commit | 15cf0b82271b1823fb02ab8c377badba614d95d5 (patch) | |
| tree | ca42bf23fa8fa35f2cb6ca80e14ccc5e89404846 /drivers/video/fbdev/i740fb.c | |
| parent | video: fbdev: i740fb: use memset_io() to clear screen (diff) | |
| download | linux-dev-15cf0b82271b1823fb02ab8c377badba614d95d5.tar.xz linux-dev-15cf0b82271b1823fb02ab8c377badba614d95d5.zip | |
video: fbdev: i740fb: Error out if 'pixclock' equals zero
The userspace program could pass any values to the driver through
ioctl() interface. If the driver doesn't check the value of 'pixclock',
it may cause divide error.
Fix this by checking whether 'pixclock' is zero in the function
i740fb_check_var().
The following log reveals it:
divide error: 0000 [#1] PREEMPT SMP KASAN PTI
RIP: 0010:i740fb_decode_var drivers/video/fbdev/i740fb.c:444 [inline]
RIP: 0010:i740fb_set_par+0x272f/0x3bb0 drivers/video/fbdev/i740fb.c:739
Call Trace:
fb_set_var+0x604/0xeb0 drivers/video/fbdev/core/fbmem.c:1036
do_fb_ioctl+0x234/0x670 drivers/video/fbdev/core/fbmem.c:1112
fb_ioctl+0xdd/0x130 drivers/video/fbdev/core/fbmem.c:1191
vfs_ioctl fs/ioctl.c:51 [inline]
__do_sys_ioctl fs/ioctl.c:874 [inline]
Signed-off-by: Zheyu Ma <zheyuma97@gmail.com>
Signed-off-by: Helge Deller <deller@gmx.de>
Diffstat (limited to 'drivers/video/fbdev/i740fb.c')
| -rw-r--r-- | drivers/video/fbdev/i740fb.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/video/fbdev/i740fb.c b/drivers/video/fbdev/i740fb.c index dd45ea8203be..09dd85553d4f 100644 --- a/drivers/video/fbdev/i740fb.c +++ b/drivers/video/fbdev/i740fb.c @@ -657,6 +657,9 @@ static int i740fb_decode_var(const struct fb_var_screeninfo *var, static int i740fb_check_var(struct fb_var_screeninfo *var, struct fb_info *info) { + if (!var->pixclock) + return -EINVAL; + switch (var->bits_per_pixel) { case 8: var->red.offset = var->green.offset = var->blue.offset = 0; |