diff options
| author |   Ahmed S. Darwish <a.darwish@linutronix.de> | 2021-02-08 23:38:09 +0100 |
|---|---|---|
| committer |   Daniel Vetter <daniel.vetter@ffwll.ch> | 2021-02-18 15:14:32 +0100 |
| commit | 51be84fc4d3a61d8ac7a9a1e5b03da7f1880c2b0 (patch) | |
| tree | ede8251f670cb5410fe47d1e417209e4eded068f /drivers/video/fbdev/omap2 | |
| parent | video: omap: Remove in_interrupt() usage. (diff) | |
| download | linux-dev-51be84fc4d3a61d8ac7a9a1e5b03da7f1880c2b0.tar.xz linux-dev-51be84fc4d3a61d8ac7a9a1e5b03da7f1880c2b0.zip | |
video: omapfb: Remove WARN_ON(in_interrupt()).
dsi_sync_vc() uses in_interrupt() to create a warning if the function is
used in non-preemptible context.
The usage of in_interrupt() in drivers is phased out and Linus clearly
requested that code which changes behaviour depending on context should
either be separated or the context be conveyed in an argument passed by the
caller, which usually knows the context.
The wait_for_completion() function (used in dsi_sync_vc_vp() and
dsi_sync_vc_l4() has already a check if it is invoked from proper
context.
Remove WARN_ON(in_interrupt()) from the driver.
Cc: linux-omap@vger.kernel.org
Signed-off-by: Ahmed S. Darwish <a.darwish@linutronix.de>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/20210208223810.388502-3-bigeasy@linutronix.de
Diffstat (limited to 'drivers/video/fbdev/omap2')
| -rw-r--r-- | drivers/video/fbdev/omap2/omapfb/dss/dsi.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/video/fbdev/omap2/omapfb/dss/dsi.c b/drivers/video/fbdev/omap2/omapfb/dss/dsi.c index 58c7aa279ab1..4aefd47695c5 100644 --- a/drivers/video/fbdev/omap2/omapfb/dss/dsi.c +++ b/drivers/video/fbdev/omap2/omapfb/dss/dsi.c @@ -2376,8 +2376,6 @@ static int dsi_sync_vc(struct platform_device *dsidev, int channel) WARN_ON(!dsi_bus_is_locked(dsidev)); - WARN_ON(in_interrupt()); - if (!dsi_vc_is_enabled(dsidev, channel)) return 0; |