diff options
| author |   Cai Huoqing <caihuoqing@baidu.com> | 2021-09-17 12:22:08 +0800 |
|---|---|---|
| committer |   Helge Deller <deller@gmx.de> | 2022-01-29 23:22:36 +0100 |
| commit | 24e9c50d7adf438cdfa7367636ee87b88e93dc3c (patch) | |
| tree | 1e7b4cf618f77c6e3ec382ce2121f103011f3c6f /drivers/video/fbdev/pxa168fb.c | |
| parent | video: fbdev: da8xx-fb: Make use of the helper function dev_err_probe() (diff) | |
| download | linux-dev-24e9c50d7adf438cdfa7367636ee87b88e93dc3c.tar.xz linux-dev-24e9c50d7adf438cdfa7367636ee87b88e93dc3c.zip | |
video: fbdev: pxa168fb: Make use of the helper function dev_err_probe()
When possible use dev_err_probe help to properly deal with the
PROBE_DEFER error, the benefit is that DEFER issue will be logged
in the devices_deferred debugfs file.
Using dev_err_probe() can reduce code size, and the error value
gets printed.
Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
Signed-off-by: Helge Deller <deller@gmx.de>
Diffstat (limited to 'drivers/video/fbdev/pxa168fb.c')
| -rw-r--r-- | drivers/video/fbdev/pxa168fb.c | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/drivers/video/fbdev/pxa168fb.c b/drivers/video/fbdev/pxa168fb.c index 47e6a1d0d229..35cf806a9219 100644 --- a/drivers/video/fbdev/pxa168fb.c +++ b/drivers/video/fbdev/pxa168fb.c @@ -606,10 +606,9 @@ static int pxa168fb_probe(struct platform_device *pdev) } clk = devm_clk_get(&pdev->dev, "LCDCLK"); - if (IS_ERR(clk)) { - dev_err(&pdev->dev, "unable to get LCDCLK"); - return PTR_ERR(clk); - } + if (IS_ERR(clk)) + return dev_err_probe(&pdev->dev, PTR_ERR(clk), + "unable to get LCDCLK"); res = platform_get_resource(pdev, IORESOURCE_MEM, 0); if (res == NULL) { |