diff options
| author |   Laurent Pinchart <laurent.pinchart@ideasonboard.com> | 2011-05-25 11:34:52 +0200 |
|---|---|---|
| committer | Laurent Pinchart <laurent.pinchart@ideasonboard.com> | 2011-08-19 10:31:09 +0200 |
| commit | d8344e090c5adff3290925cbb040d20133b7f586 (patch) | |
| tree | 55cc3ed84ceb1c73d274092135a03c55d2151835 /drivers/video/g364fb.c | |
| parent | fbdev: unicore32: use display information in info not in var for panning (diff) | |
| download | linux-dev-d8344e090c5adff3290925cbb040d20133b7f586.tar.xz linux-dev-d8344e090c5adff3290925cbb040d20133b7f586.zip | |
g364fb: use display information in info not in var for panning
We must not use any information in the passed var besides xoffset,
yoffset and vmode as otherwise applications might abuse it.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Diffstat (limited to 'drivers/video/g364fb.c')
| -rw-r--r-- | drivers/video/g364fb.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/drivers/video/g364fb.c b/drivers/video/g364fb.c index d662317d85e3..223896cc5f7d 100644 --- a/drivers/video/g364fb.c +++ b/drivers/video/g364fb.c @@ -149,10 +149,11 @@ int g364fb_cursor(struct fb_info *info, struct fb_cursor *cursor) static int g364fb_pan_display(struct fb_var_screeninfo *var, struct fb_info *info) { - if (var->xoffset || var->yoffset + var->yres > var->yres_virtual) + if (var->xoffset || + var->yoffset + info->var.yres > info->var.yres_virtual) return -EINVAL; - *(unsigned int *) TOP_REG = var->yoffset * var->xres; + *(unsigned int *) TOP_REG = var->yoffset * info->var.xres; return 0; } |