diff options
| author |   Linus Walleij <linus.walleij@linaro.org> | 2015-12-21 23:03:02 +0100 |
|---|---|---|
| committer | Linus Walleij <linus.walleij@linaro.org> | 2016-01-05 10:28:03 +0100 |
| commit | 13e676be085341c1161c3daf535e98ec6d5d6e3c (patch) | |
| tree | 5d357806a2b5039f1ac833c7d3a5dc093eeed439 /drivers/video | |
| parent | pinctrl: qcom: fix up errorpath (diff) | |
| download | linux-dev-13e676be085341c1161c3daf535e98ec6d5d6e3c.tar.xz linux-dev-13e676be085341c1161c3daf535e98ec6d5d6e3c.zip | |
fbdev: via-gpio: Be sure to clamp return value
As we want gpio_chip .get() calls to be able to return negative
error codes and propagate to drivers, we need to go over all
drivers and make sure their return values are clamped to [0,1].
We do this by using the ret = !!(val) design pattern.
Cc: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
Acked-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Diffstat (limited to 'drivers/video')
| -rw-r--r-- | drivers/video/fbdev/via/via-gpio.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/video/fbdev/via/via-gpio.c b/drivers/video/fbdev/via/via-gpio.c index 6f433b8cee12..3d3544036bc1 100644 --- a/drivers/video/fbdev/via/via-gpio.c +++ b/drivers/video/fbdev/via/via-gpio.c @@ -142,7 +142,7 @@ static int via_gpio_get(struct gpio_chip *chip, unsigned int nr) gpio = cfg->active_gpios[nr]; reg = via_read_reg(VIASR, gpio->vg_port_index); spin_unlock_irqrestore(&cfg->vdev->reg_lock, flags); - return reg & (0x04 << gpio->vg_mask_shift); + return !!(reg & (0x04 << gpio->vg_mask_shift)); } |