aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/video
diff options
context:
space:
mode:
authorTimur Tabi <timur@freescale.com>2011-09-15 16:44:55 -0500
committerFlorian Tobias Schandinat <FlorianSchandinat@gmx.de>2011-09-18 20:08:57 +0000
commit589c797193547b12c34f80048440bc1cac242fec (patch)
tree55d484a48886987c6cb783f469f39b8adc0db4d3 /drivers/video
parentdrivers/video: fsl-diu-fb: fix potential memcpy buffer overflow bug (diff)
downloadlinux-dev-589c797193547b12c34f80048440bc1cac242fec.tar.xz
linux-dev-589c797193547b12c34f80048440bc1cac242fec.zip
drivers/video: fsl-diu-fb: fix memory leak on error
We were forgetting to unmap the video memory if fsl_diu_check_var() fails. Signed-off-by: Timur Tabi <timur@freescale.com> Signed-off-by: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
Diffstat (limited to 'drivers/video')
-rw-r--r--drivers/video/fsl-diu-fb.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/video/fsl-diu-fb.c b/drivers/video/fsl-diu-fb.c
index 3776949d6183..c66f6ed57886 100644
--- a/drivers/video/fsl-diu-fb.c
+++ b/drivers/video/fsl-diu-fb.c
@@ -1200,6 +1200,7 @@ static int __devinit install_fb(struct fb_info *info)
if (fsl_diu_check_var(&info->var, info)) {
dev_err(info->dev, "fsl_diu_check_var failed\n");
+ unmap_video_memory(info);
fb_dealloc_cmap(&info->cmap);
return -EINVAL;
}