aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/video
diff options
context:
space:
mode:
authorJani Nikula <ext-jani.1.nikula@nokia.com>2010-06-01 18:08:18 +0300
committerTomi Valkeinen <tomi.valkeinen@nokia.com>2010-08-05 16:52:10 +0300
commit5cb33e2166067e1fff7ebc3b849ec70a6fd7ec1d (patch)
tree6531963d207d2adc5637f855243d0ad2c39c20f4 /drivers/video
parentOMAP: DSS2: OMAPFB: Remove redundant color register range check (diff)
downloadlinux-dev-5cb33e2166067e1fff7ebc3b849ec70a6fd7ec1d.tar.xz
linux-dev-5cb33e2166067e1fff7ebc3b849ec70a6fd7ec1d.zip
OMAP: DSS2: OMAPFB: Fix sysfs mirror input check
Using bool silently converted input to 0 or 1, making the range check useless. Use unsigned long instead, and convert to bool later. Found by Coverity. Signed-off-by: Jani Nikula <ext-jani.1.nikula@nokia.com> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@nokia.com>
Diffstat (limited to 'drivers/video')
-rw-r--r--drivers/video/omap2/omapfb/omapfb-sysfs.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/video/omap2/omapfb/omapfb-sysfs.c b/drivers/video/omap2/omapfb/omapfb-sysfs.c
index 51c13c366bf3..6f9c72cd6bb0 100644
--- a/drivers/video/omap2/omapfb/omapfb-sysfs.c
+++ b/drivers/video/omap2/omapfb/omapfb-sysfs.c
@@ -102,7 +102,7 @@ static ssize_t store_mirror(struct device *dev,
{
struct fb_info *fbi = dev_get_drvdata(dev);
struct omapfb_info *ofbi = FB2OFB(fbi);
- bool mirror;
+ unsigned long mirror;
int r;
struct fb_var_screeninfo new_var;