diff options
| author |   Heinz Graalfs <graalfs@linux.vnet.ibm.com> | 2013-10-29 09:38:50 +1030 |
|---|---|---|
| committer |   Rusty Russell <rusty@rustcorp.com.au> | 2013-10-29 11:28:11 +1030 |
| commit | 46f9c2b925ac12e5ad8b8b7c90c71dacc9d5db37 (patch) | |
| tree | 39b9bd752cb3cb43a5e11d4f0fc35f425f1d02e2 /drivers/virtio/virtio_mmio.c | |
| parent | virtio_config: remove virtio_config_val (diff) | |
| download | linux-dev-46f9c2b925ac12e5ad8b8b7c90c71dacc9d5db37.tar.xz linux-dev-46f9c2b925ac12e5ad8b8b7c90c71dacc9d5db37.zip | |
virtio_ring: change host notification API
Currently a host kick error is silently ignored and not reflected in
the virtqueue of a particular virtio device.
Changing the notify API for guest->host notification seems to be one
prerequisite in order to be able to handle such errors in the context
where the kick is triggered.
This patch changes the notify API. The notify function must return a
bool return value. It returns false if the host notification failed.
Signed-off-by: Heinz Graalfs <graalfs@linux.vnet.ibm.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Diffstat (limited to 'drivers/virtio/virtio_mmio.c')
| -rw-r--r-- | drivers/virtio/virtio_mmio.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/virtio/virtio_mmio.c b/drivers/virtio/virtio_mmio.c index 1ba0d6831015..e9fdeb861992 100644 --- a/drivers/virtio/virtio_mmio.c +++ b/drivers/virtio/virtio_mmio.c @@ -219,13 +219,14 @@ static void vm_reset(struct virtio_device *vdev) /* Transport interface */ /* the notify function used when creating a virt queue */ -static void vm_notify(struct virtqueue *vq) +static bool vm_notify(struct virtqueue *vq) { struct virtio_mmio_device *vm_dev = to_virtio_mmio_device(vq->vdev); /* We write the queue's selector into the notification register to * signal the other end */ writel(vq->index, vm_dev->base + VIRTIO_MMIO_QUEUE_NOTIFY); + return true; } /* Notify all virtqueues on an interrupt. */ |