diff options
| author |   Ihor Matushchak <ihor.matushchak@foobox.net> | 2019-07-02 17:48:18 +0300 |
|---|---|---|
| committer |   Michael S. Tsirkin <mst@redhat.com> | 2019-07-11 16:22:29 -0400 |
| commit | 5e663f0410fa2f355042209154029842ba1abd43 (patch) | |
| tree | 7e977bbddad567428fc006bb0bb18a011e696792 /drivers/virtio | |
| parent | scsi: virtio_scsi: Use struct_size() helper (diff) | |
| download | linux-dev-5e663f0410fa2f355042209154029842ba1abd43.tar.xz linux-dev-5e663f0410fa2f355042209154029842ba1abd43.zip | |
virtio-mmio: add error check for platform_get_irq
in vm_find_vqs() irq has a wrong type
so, in case of no IRQ resource defined,
wrong parameter will be passed to request_irq()
Signed-off-by: Ihor Matushchak <ihor.matushchak@foobox.net>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Ivan T. Ivanov <iivanov.xz@gmail.com>
Diffstat (limited to 'drivers/virtio')
| -rw-r--r-- | drivers/virtio/virtio_mmio.c | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/drivers/virtio/virtio_mmio.c b/drivers/virtio/virtio_mmio.c index f363fbeb5ab0..e09edb5c5e06 100644 --- a/drivers/virtio/virtio_mmio.c +++ b/drivers/virtio/virtio_mmio.c @@ -463,9 +463,14 @@ static int vm_find_vqs(struct virtio_device *vdev, unsigned nvqs, struct irq_affinity *desc) { struct virtio_mmio_device *vm_dev = to_virtio_mmio_device(vdev); - unsigned int irq = platform_get_irq(vm_dev->pdev, 0); + int irq = platform_get_irq(vm_dev->pdev, 0); int i, err, queue_idx = 0; + if (irq < 0) { + dev_err(&vdev->dev, "Cannot get IRQ resource\n"); + return irq; + } + err = request_irq(irq, vm_interrupt, IRQF_SHARED, dev_name(&vdev->dev), vm_dev); if (err) |