diff options
| author |   Dan Carpenter <dan.carpenter@oracle.com> | 2020-12-04 17:23:00 +0300 |
|---|---|---|
| committer |   Michael S. Tsirkin <mst@redhat.com> | 2020-12-18 16:14:30 -0500 |
| commit | ae93d8ea0fa701e84ab9df0db9fb60ec6c80d7b8 (patch) | |
| tree | 1bb760aab111dbde79cf27d154bf59de3490f37d /drivers/virtio | |
| parent | tools/virtio: add barrier for aarch64 (diff) | |
| download | linux-dev-ae93d8ea0fa701e84ab9df0db9fb60ec6c80d7b8.tar.xz linux-dev-ae93d8ea0fa701e84ab9df0db9fb60ec6c80d7b8.zip | |
virtio_ring: Cut and paste bugs in vring_create_virtqueue_packed()
There is a copy and paste bug in the error handling of this code and
it uses "ring_dma_addr" three times instead of "device_event_dma_addr"
and "driver_event_dma_addr".
Fixes: 1ce9e6055fa0 (" virtio_ring: introduce packed ring support")
Reported-by: Robert Buhren <robert.buhren@sect.tu-berlin.de>
Reported-by: Felicitas Hetzelt <file@sect.tu-berlin.de>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/X8pGRJlEzyn+04u2@mwanda
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Acked-by: Jason Wang <jasowang@redhat.com>
Diffstat (limited to 'drivers/virtio')
| -rw-r--r-- | drivers/virtio/virtio_ring.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c index becc77697960..924b6b85376b 100644 --- a/drivers/virtio/virtio_ring.c +++ b/drivers/virtio/virtio_ring.c @@ -1676,9 +1676,9 @@ err_desc_extra: err_desc_state: kfree(vq); err_vq: - vring_free_queue(vdev, event_size_in_bytes, device, ring_dma_addr); + vring_free_queue(vdev, event_size_in_bytes, device, device_event_dma_addr); err_device: - vring_free_queue(vdev, event_size_in_bytes, driver, ring_dma_addr); + vring_free_queue(vdev, event_size_in_bytes, driver, driver_event_dma_addr); err_driver: vring_free_queue(vdev, ring_size_in_bytes, ring, ring_dma_addr); err_ring: |