aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/virtio
diff options
context:
space:
mode:
authorChristian Borntraeger <borntraeger@de.ibm.com>2009-05-26 15:46:09 +0200
committerRusty Russell <rusty@rustcorp.com.au>2009-06-12 22:16:40 +0930
commitc89e80168ba1ed37627fe03116b0cf8474dcb7e0 (patch)
tree3314d284cca77dc81913877d1cf58838186e7e85 /drivers/virtio
parentvirtio: handle short buffers in virtio_rng. (diff)
downloadlinux-dev-c89e80168ba1ed37627fe03116b0cf8474dcb7e0.tar.xz
linux-dev-c89e80168ba1ed37627fe03116b0cf8474dcb7e0.zip
virtio: fix id_matching for virtio drivers
This bug never appeared, since all current virtio drivers use VIRTIO_DEV_ANY_ID for the vendor field. If a real vendor would be used, the check in virtio_id_match is wrong - it returns 0 if id->vendor == dev->id.vendor. Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com> Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Diffstat (limited to 'drivers/virtio')
-rw-r--r--drivers/virtio/virtio.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/virtio/virtio.c b/drivers/virtio/virtio.c
index bd0745250fd9..22642a255d32 100644
--- a/drivers/virtio/virtio.c
+++ b/drivers/virtio/virtio.c
@@ -61,7 +61,7 @@ static inline int virtio_id_match(const struct virtio_device *dev,
if (id->device != dev->id.device)
return 0;
- return id->vendor == VIRTIO_DEV_ANY_ID || id->vendor != dev->id.vendor;
+ return id->vendor == VIRTIO_DEV_ANY_ID || id->vendor == dev->id.vendor;
}
/* This looks through all the IDs a driver claims to support. If any of them