diff options
| author |   Guenter Roeck <linux@roeck-us.net> | 2016-08-09 22:34:31 -0700 |
|---|---|---|
| committer |   Wim Van Sebroeck <wim@iguana.be> | 2016-09-23 08:37:14 +0200 |
| commit | 2e91838bf7ffdedabdb29e091207d6531d04ef4f (patch) | |
| tree | 867ed2a750e4658e9c2864a6d8c0ea65ca1ba88f /drivers/watchdog/watchdog_core.c | |
| parent | Linux 4.8-rc7 (diff) | |
| download | linux-dev-2e91838bf7ffdedabdb29e091207d6531d04ef4f.tar.xz linux-dev-2e91838bf7ffdedabdb29e091207d6531d04ef4f.zip | |
watchdog: core: Fix devres_alloc() allocation size
Coverity reports:
Passing argument 152UL /* sizeof (*wdd) */ to function __devres_alloc_node
and then casting the return value to struct watchdog_device ** is
suspicious.
Allocation size needs to be sizeof(*rcwdd), not sizeof(*wdd).
Fixes: 83fbae5a148c ("watchdog: Add a device managed API for ...")
Cc: Neil Armstrong <narmstrong@baylibre.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Acked-by: Neil Armstrong <narmstrong@baylibre.com>
Signed-off-by: Wim Van Sebroeck <wim@iguana.be>
Diffstat (limited to 'drivers/watchdog/watchdog_core.c')
| -rw-r--r-- | drivers/watchdog/watchdog_core.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/watchdog/watchdog_core.c b/drivers/watchdog/watchdog_core.c index 6abb83cd7681..74265b2f806c 100644 --- a/drivers/watchdog/watchdog_core.c +++ b/drivers/watchdog/watchdog_core.c @@ -349,7 +349,7 @@ int devm_watchdog_register_device(struct device *dev, struct watchdog_device **rcwdd; int ret; - rcwdd = devres_alloc(devm_watchdog_unregister_device, sizeof(*wdd), + rcwdd = devres_alloc(devm_watchdog_unregister_device, sizeof(*rcwdd), GFP_KERNEL); if (!rcwdd) return -ENOMEM; |